Display settings and font size

[EdDressel]

Thank you for your response.

A couple of items in response:

1) Is this what you are recommending for ChangeScale:

Code: Select all

{$IFNDEF FMX}
procedure TCustomTeePanel.ChangeScale(M, D: Integer{$IFDEF D24}; isDpiChange: Boolean{$ENDIF});
begin
  inherited;

//  if M <> D then
//  begin
//    Canvas.FontZoom:=FView3DOptions.FontZoom*M/D;
//    FView3DOptions.FontZoom:=Round(Canvas.FontZoom);
//  end;
end;
{$ENDIF}

Do I also remove the "inherited;" as well?

2) Can you send attach a demo so I can test?

Much appreciated.

Ed Dressel

[Yeray]

Hello,

Do I also remove the "inherited;" as well?

In the tests I've done here I don't see any difference but in general I would leave the inherited or remove the full override method.

Can you send attach a demo so I can test?

Sure. Here it is.

[EdDressel]

Thank you for the quick response.

Can I get the source to the demo as well?

[Yeray]

Can I get the source to the demo as well?

Sure!

Display Size.zip

(25.82 KiB) Downloaded 1604 times

[EdDressel]

Thank you.

From our testing, we believe it is fixed. We will be releasing it to our customers next week.

Ed Dressel

[Yeray]

Great! Thanks for the feedback.

[Yeray]

Hello,

This is just to inform another change had been introduced affecting DPI awareness and ChangeScale. This change entered the main branch a few days after v2021.33 was released so, if nothing changes, the next release will be the first to include this code:

Code: Select all

    {$IFNDEF FMX}
    procedure ChangeScale(M, D: Integer{$IFDEF D24}; isDpiChange: Boolean{$ENDIF}); override;
    {$ENDIF}

Code: Select all

{$IFNDEF FMX}
procedure TCustomTeePanel.ChangeScale(M, D: Integer{$IFDEF D24}; isDpiChange: Boolean{$ENDIF});
begin
  inherited;

  if not (csLoading in Self.ComponentState) and (M <> D) then
  begin
    Canvas.FontZoom:=MulDiv(FView3DOptions.FontZoom, M, D);
    FView3DOptions.FontZoom:=Round(Canvas.FontZoom);
  end;
end;
{$ENDIF}

It's basically the same code here with a new not (csLoading in Self.ComponentState) condition.